Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add cancelAllNotifications optional android tag property #1087

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

DanielFRico
Copy link
Contributor

cancelAllNotifications signature optional tag property is added. This is useful when we need to delete remote notifications

… This is useful when we need to delete remote notifications
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋 - sorry for the delay, indeed this looks like a good type fix, the functionality has existed for 3 years but the type signature did not reflect it

@mikehardy mikehardy added the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Sep 11, 2024
@mikehardy mikehardy changed the title fix: cancelAllNotifications signature optional tag property is added fix(types): add cancelAllNotifications optional android tag property Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (c9593cd) to head (733e846).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files          32       32           
  Lines        1699     1699           
  Branches      572      572           
=======================================
  Hits         1313     1313           
  Misses        336      336           
  Partials       50       50           

@mikehardy mikehardy merged commit 134e00a into invertase:main Sep 11, 2024
11 of 12 checks passed
@mikehardy mikehardy removed the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Sep 11, 2024
@mikehardy
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants